dvlahovski added a comment. In https://reviews.llvm.org/D25196#559368, @amccarth wrote:
> I was hoping that, with your new mini dump parser, you'd be able to eliminate > the need for the Windows-specific minidump process plugin. > > When I wrote the Windows mini dump plugin, I tried to isolate the Windows > API-specific bits using the pimpl idiom. Now that you've written a mini dump > parser, we shouldn't need the Windows API calls, and nearly all the rest of > the code should be shareable between Windows and Linux. Is there a plan to > eliminate this redundancy and merge this new mini dump process plugin with > the Windows-specific one? Yes, the plan is that my plugin will replace the Windows one. (and it has almost the same functionality) What I have been doing so far is actually copying all of the methods from the WinMinidump plugin to mine and changing them to use the new Minidump parser. Probably I could have fitted into you pimpl implementation pattern, but I chose just to start a 'new' plugin and copy everything from the WinMinidump, and then change it accordingly. https://reviews.llvm.org/D25196 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
