labath wrote:

So, it sounds like this is fixing 
test/API/commands/process/detach-resumes/TestDetachResumes.py (which is linked 
to #89077, which may be a dupe of the bug you're referencing), so the first 
step would be to figure out whether this test actually passes with your patch. 
Note that the test was never successfully run on windows, so you may need to 
tweak it a bit to make it windows compatible (I don't see anything that should 
be a problem for windows, but it's very easy for os assumptions to sneak in).

I'm not really familiar with windows APIs, but the change doesn't seem 
particularly controversial.

https://github.com/llvm/llvm-project/pull/115712
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to