mstorsjo wrote: > The amount of churn is already pretty high -- please make sure the original > commit, fixes, and reverts get added to > https://github.com/llvm/llvm-project/blob/main/.git-blame-ignore-revs. At the > end of the day, we have a number of tests and files which are sensitive to > line endings and we have a lot of existing clones of the repo which have been > set up to work properly with the current setup, so this is a risky change.
FWIW, while I'm not a fan of checking things out with CRLF per se (or making `core.autocrlf` no longer have precedence), I totally don't mind fixing tests (or in most cases, adding some individual files to `.gitattributes` to mark them as needing to be checked out with LF newlines always), and I don't consider that part churn. We have a number of such files marked that way from before, but we clearly do need to add a few more. But I haven't checked all the commits that have gone in to try to fix up tests that were failing due to CRLF - in case some of them really should be reverted once we're back to checking things out with LF. https://github.com/llvm/llvm-project/pull/86318 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
