AaronBallman wrote:

> But if every single Windows developer involved here say that they want LF, 
> and they don't want any ambiguity about it? Is it more important to give 
> hypothetical users the choice to pick what they like, at the cost of every 
> single current developer who do not want that, and breaking every established 
> setup routine?

+1; I was [on the 
fence](https://github.com/llvm/llvm-project/pull/86318#pullrequestreview-2023166237)
 about the changes because what happened here has [happened 
before](https://github.com/llvm/llvm-project/pull/86318#issuecomment-2427230026).

The amount of churn is already pretty high -- please make sure the original 
commit, fixes, and reverts get added to 
https://github.com/llvm/llvm-project/blob/main/.git-blame-ignore-revs. At the 
end of the day, we have a number of tests and files which are sensitive to line 
endings and we have a lot of existing clones of the repo which have been set up 
to work properly with the current setup, so this is a risky change.

Has there been a recent RFC asking if the community wants to go down this path? 
If not, we should run one before attempting further changes (aside from fixing 
anything up that still needs fixing, if anything).

https://github.com/llvm/llvm-project/pull/86318
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to