Stefan =?utf-8?q?Gränitz?= <[email protected]>,
Stefan =?utf-8?q?Gränitz?= <[email protected]>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
================
@@ -272,6 +272,8 @@ def parseOptionsAndInitTestdirs():
configuration.make_path = "gmake"
else:
configuration.make_path = "make"
+ if ' ' in configuration.make_path:
+ configuration.make_path = f'"{configuration.make_path}"'
----------------
labath wrote:
That may be fine, but I think this is the wrong place to quote it. I think it
should happen somewhere around the place where this variable is concatenated
into a string (or passed to whatever it is that requires it to be quoted).
That said, after tracing this variable, I'm a little unsure as to why is this
needed. IIUC, this eventually makes its way to the `subprocess.check_output`
call
[here](https://github.com/llvm/llvm-project/blob/f1eac7761704fa4e16c2619a84890baad380fdce/lldb/packages/Python/lldbsuite/test/lldbtest.py#L1499),
which should be able to handle quoting on its own.
Can you explain what the problem was without this?
https://github.com/llvm/llvm-project/pull/111531
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
