On Tue, Mar 29, 2016 at 8:43 AM, Zachary Turner <ztur...@google.com> wrote:
> It's night here, so I will have a detailed look tomorrow. But in the > meantime, some of the issues don't appear to be addressed. For example the > issue about why logging is disabled, > Fixed with the new patch > the disabled code in ProcessWinMiniDump.cpp, > Fixed > and a few other things. If you view the diff in Phabricator, you can > respond inline to each of those with some kind of explanation if possible. > > On Mon, Mar 28, 2016 at 10:26 PM Eran Ifrah <eran.if...@gmail.com> wrote: > >> eran.ifrah updated this revision to Diff 51873. >> eran.ifrah marked 21 inline comments as done. >> eran.ifrah added a comment. >> >> An updated patch that fixes all your comments and in includes this one as >> well: http://reviews.llvm.org/D18520 >> I also added new command line argument option to `CMake` : >> `-DMINGW_DEBUG=1` when passed from the command line, it adds `-g -O0` to >> the LLDB sources (only LLDB) >> Using the standard way `-DCMAKE_BUILD_TYPE=Debug` creates file too large >> for MinGW to handle >> >> >> http://reviews.llvm.org/D18519 >> >> Files: >> CMakeLists.txt >> cmake/modules/AddLLDB.cmake >> cmake/modules/LLDBConfig.cmake >> include/lldb/Host/windows/win32.h >> source/API/SystemInitializerFull.cpp >> source/Host/common/OptionParser.cpp >> source/Host/windows/EditLineWin.cpp >> source/Host/windows/FileSystem.cpp >> source/Host/windows/ProcessRunLock.cpp >> source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp >> source/Plugins/Process/Windows/Common/ProcessWindowsLog.h >> source/Target/ProcessLaunchInfo.cpp >> source/Utility/PseudoTerminal.cpp >> tools/CMakeLists.txt >> tools/argdumper/CMakeLists.txt >> tools/driver/CMakeLists.txt >> tools/driver/Driver.cpp >> >> -- Eran Ifrah, Author of codelite, a cross platform open source C/C++ IDE: http://www.codelite.org CodeLite IDE Blog: http://codeliteide.blogspot.com/
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
