Eugene.Zelenko added inline comments. ================ Comment at: source/Plugins/Language/Go/GoFormatterFunctions.h:1 @@ +1,2 @@ +//===-- GoFormatterFunctions.h------------------------------------*- C++ -*-===// +// ---------------- Such comments should be 80 characters long.
================ Comment at: source/Plugins/Language/Go/GoFormatterFunctions.h:15 @@ +14,3 @@ +#include <time.h> + +#include "lldb/lldb-forward.h" ---------------- Please add headers sections comments. Same for other sections. Clang headers should be before LLDB. ================ Comment at: source/Plugins/Language/Go/GoLanguage.cpp:11 @@ +10,3 @@ +#include "GoLanguage.h" + +#include <string.h> ---------------- Please add headers sections comments. GoLanguage.h should be in LLDB headers section. Repository: rL LLVM http://reviews.llvm.org/D13878 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
