Eugene.Zelenko added a subscriber: Eugene.Zelenko. ================ Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10 @@ +9,3 @@ + +#include <vector> + ---------------- Please add include section comments. Same for other sections.
================ Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:98 @@ +97,3 @@ + + ~GoSliceSyntheticFrontEnd () override = default; + ---------------- Please place destructor near constructor. ================ Comment at: source/Plugins/Language/Go/GoLanguage.cpp:49 @@ +48,3 @@ +} + + ---------------- Please use consistent spacing between methods. ================ Comment at: source/Plugins/Language/Go/GoLanguage.h:31 @@ +30,3 @@ + public: + virtual ~GoLanguage() = default; + ---------------- Please use override instead of virtual. ================ Comment at: source/Plugins/Language/Go/GoLanguage.h:34 @@ +33,3 @@ + GoLanguage () = default; + + lldb::LanguageType ---------------- Please place constructor before destructor. ================ Comment at: source/Plugins/Language/Go/GoLanguage.h:65 @@ +64,3 @@ + //------------------------------------------------------------------ + virtual ConstString + GetPluginName() override; ---------------- virtual is not needed. Please run clang-tidy modernize-use-override. Same for GetPluginVersion(). Repository: rL LLVM http://reviews.llvm.org/D13878 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
