2009/12/24 Przemysław Firszt <[email protected]>: >> Dnia 2009-12-23, śro o godzinie 11:53 -0800, Ping pisze: >> > 2009/12/23 Przemysław Firszt <[email protected]>: > [..] >> > > Question two: a tilt table value contains an angle (shifted by 8 bits). >> > > Are we using it or are we going to use that angle somewhere? >> > > The wcmTilt2R doesn't use it: >> > > [..] >> > > xyTable = cTable[tilt_x]; >> > > ds->rotation = (xyTable[tilt_y-tilt_x] & 0xFF) + offset; >> > > [..] >> > > -- >> > >> > Beats me :). I have to read the code again to know what I was doing. >> > But, I am not in the mood to read that part of the code yet... If you >> > can not wait, please leave the shift there with your comments when you >> > create the new code. We can modify it later when I have time to >> > review it. > Ping, > See attached first-step reduction of code volume. I prepared it in case > you have too much spare time and you would like to test something not > important ;-)
I am glad that I've managed to get back to you before 2010 (my time). First of all, your change is fine since in the code we indeed don't need the latitude. The "history" of the code is: the tilt can be translated into rotation for both Wacom styli and mice (it is a standard translation). So, the original code was for both stylus and puck. However, the particular case we are talking about, Intuos 4 mouse, have a fixed latitude since mouse is always "flat" on the surface. That is why the other angles are not used. With this said, your patch can be accepted without problem. However, since you are on this page and you feel comfortable to simply the code, can you "cook" something more for us? Can you make a routine to cover all the tables so we can get rid of this file and move the routine to wcmCommon.c (or another reasonale file as you wished :)? Ping ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
