Hi André, Am 26.10.2016 um 22:50 schrieb André Przywara: > On 26/10/16 19:51, Jagan Teki wrote: >> On Fri, Oct 21, 2016 at 5:41 AM, Andre Przywara <[email protected]> >> wrote: >>> The sun8i-emac driver works fine with the A64 Ethernet IP, but we are >>> missing an alias entry to trigger the driver instantiation by U-Boot. >>> Add the line to point U-Boot to the Ethernet DT node. >>> This enables TFTP boot on the Pine64. >>> >>> Signed-off-by: Andre Przywara <[email protected]> >>> --- >>> arch/arm/dts/sun50i-a64-pine64-common.dtsi | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/dts/sun50i-a64-pine64-common.dtsi >>> b/arch/arm/dts/sun50i-a64-pine64-common.dtsi >>> index d5a7249..c0fde44 100644 >>> --- a/arch/arm/dts/sun50i-a64-pine64-common.dtsi >>> +++ b/arch/arm/dts/sun50i-a64-pine64-common.dtsi >>> @@ -46,6 +46,7 @@ >>> >>> aliases { >>> serial0 = &uart0; >>> + ethernet0 = &emac; >> >> Better to have this alias on sun50i-a64.dtsi since the node is defined there? > > Mmh, I find examples for both ways (.dtsi vs. .dts) in the kernel. I > need to learn what's the best practice here.
Last I was told by kernel maintainers (in an Amlogic context) aliases should be in the board's .dts[i] so that only the enabled nodes get numbered. If they're enabled at .dtsi level then I guess nothing is wrong with having the alias there. So I'm guessing the patch is good. Reviewed-by: Andreas Färber <[email protected]> Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
