On 26/10/16 19:51, Jagan Teki wrote: Hi, > On Fri, Oct 21, 2016 at 5:41 AM, Andre Przywara <[email protected]> > wrote: >> The sun8i-emac driver works fine with the A64 Ethernet IP, but we are >> missing an alias entry to trigger the driver instantiation by U-Boot. >> Add the line to point U-Boot to the Ethernet DT node. >> This enables TFTP boot on the Pine64. >> >> Signed-off-by: Andre Przywara <[email protected]> >> --- >> arch/arm/dts/sun50i-a64-pine64-common.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/dts/sun50i-a64-pine64-common.dtsi >> b/arch/arm/dts/sun50i-a64-pine64-common.dtsi >> index d5a7249..c0fde44 100644 >> --- a/arch/arm/dts/sun50i-a64-pine64-common.dtsi >> +++ b/arch/arm/dts/sun50i-a64-pine64-common.dtsi >> @@ -46,6 +46,7 @@ >> >> aliases { >> serial0 = &uart0; >> + ethernet0 = &emac; > > Better to have this alias on sun50i-a64.dtsi since the node is defined there?
Mmh, I find examples for both ways (.dtsi vs. .dts) in the kernel. I need to learn what's the best practice here. But the U-Boot DTs need to get replaced anyway soon-ish, since the Linux DTs (which are WIP) have already diverged. So what about we keep this alias here next to the existing one for the 2016.11 release and possibly fix this later once we replace the DTs anyway with what gets merged into the kernel eventually? In the end of the day it's an easy and obvious fix which makes many people happy (since it allows TFTP boot of the Pine64). Cheers, Andre. -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
