Hi Vineet, > -----Original Message----- > From: Vineet Gupta <vgu...@synopsys.com> > Sent: Thursday, May 16, 2019 8:38 PM > To: Eugeniy Paltsev <palt...@synopsys.com> > Cc: palt...@snyopsys.com; linux-ker...@vger.kernel.org; Alexey Brodkin > <abrod...@synopsys.com>; linux- > snps-...@lists.infradead.org > Subject: Re: [PATCH 4/9] ARC: mm: do_page_fault refactor #3: tidyup vma > access permission code > > On 5/16/19 10:24 AM, Eugeniy Paltsev wrote: > >> + unsigned int write = 0, exec = 0, mask; > > Probably it's better to use 'bool' type for 'write' and 'exec' as we really > > use them as a boolean > variables. > > Right those are semantics, but the generated code for "bool" is not ideal - > given > it is inherently a "char" it is promoted first to an int with an additional > EXTB > which I really dislike. > Guess it is more of a style thing.
In that sense maybe think about re-definition of "bool" type to 32-bit one for entire architecture and get that benefit across the entire source tree? -Alexey
