On Thu, Nov 03, 2016 at 10:57:48AM -0700, Vineet Gupta wrote: > Hi Daniel, > > On 11/03/2016 09:50 AM, Daniel Lezcano wrote: > > On Thu, Nov 03, 2016 at 09:40:23AM -0700, Vineet Gupta wrote: > >> On 11/01/2016 06:03 PM, Vineet Gupta wrote: > >>>>> Because of the git mv you, diff didn't include bulk of driver code > >>>>> which would > >>>>>>> make for bulk of review anyways. So perhaps in v2 I don't do the git > >>>>>>> mv. OK ? > >>>>> > >>>>> That means I will review and comment existing code. It is not a problem > >>>>> for me > >>>>> if you agree to do the changes. > >>> Sure, the whole point is to make things better as an outcome of review. I > >>> have no > >>> issues changing code provided we don't add major performance regressions. > >> > >> So just wondering if I could have some comments on the initial import of > >> driver > >> before I send out a v2. > > > > Yeah, ok. Let me comment the other patches of the series and then you can > > send a V2. > > Thx for taking a quick look - this is a good start. How about the actual > driver > itself, do you want to take a quick look there as well before v2 ?
At the first glance, with your changes it is acceptable to be moved. Perhaps, you can have a look to remove the BIG_ENDIAN stuff in the clock read function. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
