On 08/12/2013 09:49 AM, [email protected] wrote: > From: Dinh Nguyen <[email protected]> > > Add bindings for SD/MMC for SOCFPGA. > Add "syscon" to the "altr,sys-mgr" binding.
> diff --git a/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt > b/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt I think it's reasonable to define one binding as being based on another plus some additions, so, the binding, Acked-by: Stephen Warren <[email protected]> > +Example: > + dwmmc0@ff704000 { > + compatible = "altr,socfpga-dw-mshc", "snps,dw-mshc"; > + altr,dw-mshc-sdr-timing = <0 3>; > + }; It'd be nice to provide a complete example though, rather than only including the properties that this binding adds to the base binding. > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > sysmgr@ffd08000 { > - compatible = "altr,sys-mgr"; > + compatible = "altr,sys-mgr", "syscon"; That seems like an unrelated change? -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
