[PATCH 3/6] uvcvideo: Don't fail when an unsupported format is requested

[Laurent Pinchart]

Return the default format in that case.

This issue was found by the v4l2-compliance tool.

Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
---
 drivers/media/usb/uvc/uvc_v4l2.c  |   11 ++++++-----
 drivers/media/usb/uvc/uvc_video.c |    1 +
 drivers/media/usb/uvc/uvcvideo.h  |    1 +
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c
index e5817b9..3bd9373 100644
--- a/drivers/media/usb/uvc/uvc_v4l2.c
+++ b/drivers/media/usb/uvc/uvc_v4l2.c
@@ -165,17 +165,18 @@ static int uvc_v4l2_try_format(struct uvc_streaming 
*stream,
                        fcc[0], fcc[1], fcc[2], fcc[3],
                        fmt->fmt.pix.width, fmt->fmt.pix.height);
 
-       /* Check if the hardware supports the requested format. */
+       /* Check if the hardware supports the requested format, use the default
+        * format otherwise.
+        */
        for (i = 0; i < stream->nformats; ++i) {
                format = &stream->format[i];
                if (format->fcc == fmt->fmt.pix.pixelformat)
                        break;
        }
 
-       if (format == NULL || format->fcc != fmt->fmt.pix.pixelformat) {
-               uvc_trace(UVC_TRACE_FORMAT, "Unsupported format 0x%08x.\n",
-                               fmt->fmt.pix.pixelformat);
-               return -EINVAL;
+       if (i == stream->nformats) {
+               format = stream->def_format;
+               fmt->fmt.pix.pixelformat = format->fcc;
        }
 
        /* Find the closest image size. The distance between image sizes is
diff --git a/drivers/media/usb/uvc/uvc_video.c 
b/drivers/media/usb/uvc/uvc_video.c
index 1c15b42..0250d17 100644
--- a/drivers/media/usb/uvc/uvc_video.c
+++ b/drivers/media/usb/uvc/uvc_video.c
@@ -1810,6 +1810,7 @@ int uvc_video_init(struct uvc_streaming *stream)
        probe->bFormatIndex = format->index;
        probe->bFrameIndex = frame->bFrameIndex;
 
+       stream->def_format = format;
        stream->cur_format = format;
        stream->cur_frame = frame;
 
diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
index 3764040..7244455 100644
--- a/drivers/media/usb/uvc/uvcvideo.h
+++ b/drivers/media/usb/uvc/uvcvideo.h
@@ -436,6 +436,7 @@ struct uvc_streaming {
        struct uvc_format *format;
 
        struct uvc_streaming_control ctrl;
+       struct uvc_format *def_format;
        struct uvc_format *cur_format;
        struct uvc_frame *cur_frame;
        /* Protect access to ctrl, cur_format, cur_frame and hardware video
-- 
1.7.8.6

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html