Hi Laurent,
You were right about your remark about setting USE_FH_PRIO: you do need to do
that here.
Thanks for reposting with more context, now I can see where the prio checks are
added :-)
I have just one small remark:
On Fri November 23 2012 13:32:05 Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 3 ++
> drivers/media/usb/uvc/uvc_v4l2.c | 45
> ++++++++++++++++++++++++++++++++++++
> drivers/media/usb/uvc/uvcvideo.h | 1 +
> 3 files changed, 49 insertions(+), 0 deletions(-)
>
> Resent with larger contexts to make review easier.
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c
> b/drivers/media/usb/uvc/uvc_driver.c
> index ae24f7d..22f14d2 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -651,10 +668,14 @@ static long uvc_v4l2_do_ioctl(struct file *file,
> unsigned int cmd, void *arg)
> ret = uvc_ctrl_rollback(handle);
> break;
> }
>
> case VIDIOC_S_EXT_CTRLS:
> + ret = v4l2_prio_check(vdev->prio, handle->vfh.prio);
> + if (ret < 0)
> + return ret;
Please add a /* fall through */ comment here.
> +
> case VIDIOC_TRY_EXT_CTRLS:
> {
> struct v4l2_ext_controls *ctrls = arg;
> struct v4l2_ext_control *ctrl = ctrls->controls;
> unsigned int i;
After making that change you can add my Acked-by:
Acked-by: Hans Verkuil <hans.verk...@cisco.com>
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
