1. Rename uevent handler to mei_cl_device_uevent 2. Add kdoc for uevent and mod alias functions
Signed-off-by: Tomas Winkler <[email protected]> --- drivers/misc/mei/bus.c | 43 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index b14662787d7e..201019c5f766 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -462,8 +462,17 @@ static int mei_cl_device_remove(struct device *dev) return cldrv->remove(cldev); } +/** + * name_show - client device name sysfs entry + * + * @dev: device + * @a: device attribute + * @buf: a buffer to fill + * + * Return: bytes to read or < 0 on error + */ static ssize_t name_show(struct device *dev, struct device_attribute *a, - char *buf) + char *buf) { struct mei_cl_device *cldev = to_mei_cl_device(dev); size_t len; @@ -474,8 +483,17 @@ static ssize_t name_show(struct device *dev, struct device_attribute *a, } static DEVICE_ATTR_RO(name); +/** + * uuid_show - client uuid sysfs entry + * + * @dev: device + * @a: device attribute + * @buf: a buffer to fill + * + * Return: bytes to read or < 0 on error + */ static ssize_t uuid_show(struct device *dev, struct device_attribute *a, - char *buf) + char *buf) { struct mei_cl_device *cldev = to_mei_cl_device(dev); const uuid_le *uuid = mei_me_cl_uuid(cldev->me_cl); @@ -487,6 +505,15 @@ static ssize_t uuid_show(struct device *dev, struct device_attribute *a, } static DEVICE_ATTR_RO(uuid); +/** + * modalias_show - modalias sysfs entry + * + * @dev: device + * @a: device attribute + * @buf: a buffer to fill + * + * Return: bytes to read or < 0 on error + */ static ssize_t modalias_show(struct device *dev, struct device_attribute *a, char *buf) { @@ -509,7 +536,15 @@ static struct attribute *mei_cl_dev_attrs[] = { }; ATTRIBUTE_GROUPS(mei_cl_dev); -static int mei_cl_uevent(struct device *dev, struct kobj_uevent_env *env) +/** + * mei_cl_device_uevent - me client bus uevent handler + * + * @dev: device + * @env: uevent kobject + * + * Return: 0 on success -ENOMEM on when add_uevent_var fails + */ +static int mei_cl_device_uevent(struct device *dev, struct kobj_uevent_env *env) { struct mei_cl_device *cldev = to_mei_cl_device(dev); const uuid_le *uuid = mei_me_cl_uuid(cldev->me_cl); @@ -533,7 +568,7 @@ static struct bus_type mei_cl_bus_type = { .match = mei_cl_device_match, .probe = mei_cl_device_probe, .remove = mei_cl_device_remove, - .uevent = mei_cl_uevent, + .uevent = mei_cl_device_uevent, }; static void mei_cl_dev_release(struct device *dev) -- 2.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
