On Fri, 13 Mar 2015 16:43:43 -0700 Joe Perches <[email protected]> wrote:
> Currently checkpatch will fuss if one uses world writable
> settings in debugfs files and DEVICE_ATTR uses by testing
> S_IWUGO but not testing S_IWOTH, S_IRWXUGO or S_IALLUGO.
>
> Extend the check to catch all cases exporting world writable
> permissions including octal values.
>
> @@ -443,6 +443,14 @@ foreach my $entry (@mode_permission_funcs) {
> $mode_perms_search .= $entry->[0];
> }
>
> +$our $mode_perms_world_writable = qr{
> + S_IWUGO |
> + S_IWOTH |
> + S_IRWXUGO |
> + S_IALLUGO |
> + 0[0-7][0-7][2367]
> +}x;
> +
Scalar found where operator expected at scripts/checkpatch.pl line 446, near
"$our $mode_perms_world_writable"
(Missing operator before $mode_perms_world_writable?)
Global symbol "$our" requires explicit package name at scripts/checkpatch.pl
line 446.
syntax error at scripts/checkpatch.pl line 446, near "$our
$mode_perms_world_writable "
Global symbol "$mode_perms_world_writable" requires explicit package name at
scripts/checkpatch.pl line 446.
BEGIN not safe after errors--compilation aborted at scripts/checkpatch.pl line
663.
akpm3:/usr/src/25> perl --version
This is perl 5, version 18, subversion 2 (v5.18.2) built for
x86_64-linux-gnu-thread-multi
This?
--- a/scripts/checkpatch.pl~checkpatch-match-more-world-writable-permissions-fix
+++ a/scripts/checkpatch.pl
@@ -443,7 +443,7 @@ foreach my $entry (@mode_permission_func
$mode_perms_search .= $entry->[0];
}
-$our $mode_perms_world_writable = qr{
+our $mode_perms_world_writable = qr{
S_IWUGO |
S_IWOTH |
S_IRWXUGO |
_
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
