On Tue, 2014-11-04 at 12:15 +0100, Jan Kara wrote: > On Mon 03-11-14 20:04:41, Joe Perches wrote: > > Use more standard logging style and remove __func__ passed > > to quota_err. > > > > Remove the quota_error macro, rename __quota_error to quota_err. > > Add %pf and __builtin_return_address(0) instead of __func__ [] > Changing > __func__ to __builtin_return_address(0) is mostly pointless. OK, saves you > 600 bytes but quota isn't really aimed at embedded systems and it reduces > usefullness of the message because of inlining.
That doesn't make any sense to me. __quota_error or quota_err is specifically not inlined. It's EXPORT_SYMBOL. > Adding '\n' at the end of > messages instead of doing it automatically in quota_error() is also IMO > pointless churn (there are other error reporting functions in kernel which > do this so it's not like we have a consensus on this). Fewer and fewer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
