On Fri, Mar 14, 2014 at 6:39 PM, Luis R. Rodriguez <[email protected]> wrote: > On Thu, Mar 13, 2014 at 11:26:25AM -0700, Cong Wang wrote: >> On Wed, Mar 12, 2014 at 8:15 PM, Luis R. Rodriguez >> <[email protected]> wrote: >> > spin_unlock_bh(&p->br->lock); >> > + if (changed) >> > + call_netdevice_notifiers(NETDEV_CHANGEADDR, >> > + p->br->dev); >> > + netdev_update_features(p->br->dev); >> >> I think this is supposed to be in netdev event handler of br->dev >> instead of here. > > Do you mean netdev_update_features() ? I mimic'd what was being done on > br_del_if() given that root blocking is doing something similar. If > we need to change something for the above then I suppose it means we need > to change br_del_if() too. Let me know if you see any reason for something > else. >
Yeah, for me it looks like it's better to call netdev_update_features() in the event handler of br->dev, rather than where calling call_netdevice_notifiers(..., br->dev);. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
