Hi all, On Mon, 24 Feb 2014 15:17:32 +1100 Stephen Rothwell <[email protected]> wrote: > > I guess that there may be more places where "asmlinkage" is used with > "static" - I assume that they are all incorrect? > > $ git grep -l 'static.*asmlinkage' > arch/x86/crypto/sha1_ssse3_glue.c > arch/x86/crypto/sha256_ssse3_glue.c > arch/x86/crypto/sha512_ssse3_glue.c
In fact, my x86_64 allmodconfig build produces these:
arch/x86/crypto/sha1_ssse3_glue.c:43:1: warning: 'externally_visible' attribute
have effect only on public objects [-Wattributes]
static asmlinkage void (*sha1_transform_asm)(u32 *, const char *, unsigned
int);
^
arch/x86/crypto/sha256_ssse3_glue.c:56:1: warning: 'externally_visible'
attribute have effect only on public objects [-Wattributes]
static asmlinkage void (*sha256_transform_asm)(const char *, u32 *, u64);
^
arch/x86/crypto/sha512_ssse3_glue.c:55:1: warning: 'externally_visible'
attribute have effect only on public objects [-Wattributes]
static asmlinkage void (*sha512_transform_asm)(const char *, u64 *, u64);
^
mm/process_vm_access.c:422:1: warning: 'externally_visible' attribute have
effect only on public objects [-Wattributes]
{
^
That last is added by commit 700d00f85598 ("mm/process_vm_access.c: mark
function as static") from the akpm-current tree.
So is "static asmlinkage" not allowed?
--
Cheers,
Stephen Rothwell [email protected]
pgpVzKO3pn4Gd.pgp
Description: PGP signature
