On Mon, 02 Dec 2013, Alexander Shiyan wrote: > > > > Понедельник, 2 декабря 2013, 10:56 UTC от Lee Jones <[email protected]>: > > On Sat, 30 Nov 2013, Alexander Shiyan wrote: > > > > > > On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > > > > > If this driver being loaded from devicetree, the pdata is NULL. > > > > > This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or > > > > > "fsl,mc13xxx-uses-touch" properties is specified. > > > > > > > > > > mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0, icid: 2/0 > > > > > Unable to handle kernel NULL pointer dereference at virtual address > > > > > 00000018 > > > ... > > > > > - if (mc13xxx->flags & MC13XXX_USE_TOUCHSCREEN) > > > > > + if ((mc13xxx->flags & MC13XXX_USE_CODEC) && pdata) > > > > > > > > Why do we check for CODEC if the Touchscreen should be used? > > > > > > Oops, my fault, copy/paste bug. > > > I'll send the corrected version. > > > > No, please don't. > > > > Just provide proper Device Tree support. > > I still have two incomplete MC13XXX DT-related patches. > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/175099.html > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-July/182116.html
Patches from June and July are no longer pending. They need to be refreshed if you stand any chance of then being accepted. > I'll resume to work on this (and CODEC & TS too). Okay, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
