On Thu, Sep 26, 2013 at 06:09:51PM -0700, Sudeep Dutt wrote:
> + Use DEVICE_ATTR_RO/RW instead of DEVICE_ATTR
> + Use ATTRIBUTE_GROUPS
>
> These changes were suggested by Greg Kroah-Hartman during the
> code review @ https://lkml.org/lkml/2013/9/6/13
>
> Signed-off-by: Ashutosh Dixit <[email protected]>
> Signed-off-by: Dasaratharaman Chandramouli
> <[email protected]>
> Signed-off-by: Nikhil Rao <[email protected]>
> Signed-off-by: Harshavardhan R Kharche <[email protected]>
> Signed-off-by: Sudeep Dutt <[email protected]>
> ---
Ok, new kernel developer 101 training time :)
Your Subject:, while the [PATCH] part is fine the rest of the line needs
to be a bit more descriptive.
As this is the "mic" subsystem, how about something like:
Subject: [PATCH 1/4] misc: mic: host driver sysfs cleanups
No need for the whole "Intel MIC" stuff.
Also, as I "reported" this, you should have a:
Reported-by: Greg Kroah-Hartman <...>
line in the patch.
And really, all of those people reviewed and signed off on the patch?
That's great, just not a normal thing.
So, can you resend these 4 patches with those things cleaned up? Same
thing goes for Joe's patch, he deserves a "Reported-by:" at the very
least, given that he pretty much wrote that whole patch.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
