On Thu, Jul 25, 2013 at 8:38 AM, Prashant Shah <[email protected]> wrote: > On Thu, Jul 25, 2013 at 10:49 AM, Prashant Shah <[email protected]> > wrote: >>> You should also remove the definition of DRV_NAME, since it is no longer >>> used. The changelog should probably mention that this will change the >>> interrupt name (which appears in /proc/interrupts for example) from "wd" >>> to "eth%d". > > I was going through the code. The apne driver apne.c in the same > folder is using DRV_NAME in request_region() > >> if (!request_region(IOBASE, 0x20, DRV_NAME)) { > > I can change the wd.c request_region() code to use DRV_NAME. Currently > it is using a string constant. > >> r = request_region(base_addr, WD_IO_EXTENT, "wd-probe"); > > This will make it more consistent. Please suggest which change is more > preferable.
If you convert each driver to use devres API, you may avoid a lot of useless work. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
