On Tue, 4 Jun 2013 12:57:06 +0200, Linus Walleij <[email protected]> wrote: > On Mon, Jun 3, 2013 at 3:42 PM, Lee Jones <[email protected]> wrote: > > > In this patch we're populating a clk_data array, one clock per element to > > act as a clk look-up using indexes supplied from Device Tree. > > > > Cc: Mike Turquette <[email protected]> > > Signed-off-by: Lee Jones <[email protected]> > > This needs to be patch 1/21 because otherwise the rest of the > stuff is non-bisectable right? It's being broken the first time > you remove auxdata and not fixed until this patch. > > The whole thing is very different from other DT clock things > I've seen, usually you add a compatible node for each > clock type, and a node for each physical gate. But there > may be several ways to skin this cat...
The design choice made here is perfectly fine by me. There has never been a requirement to expose every clock as a separate node, and for SoCs with complex clock control blocks I can certainly appreciate not wanting to expose how the internal clocks interact out to the device tree, especially if only the leaf clocks ever get reverenced by device drivers. As long as there is a driver there that understands the binding and hands out the correct clock when asked, then this design is great. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
