On Tue, Nov 13, 2012 at 01:31:55AM +0900, Joonsoo Kim wrote: > It is somehow strange that alloc_bootmem return virtual address > and free_bootmem require physical address. > Anyway, free_bootmem()'s first parameter should be physical address. > > There are some call sites for free_bootmem() with virtual address. > So fix them. > > Cc: Andrew Morton <[email protected]> > Cc: Benjamin Herrenschmidt <[email protected]> > Signed-off-by: Joonsoo Kim <[email protected]>
Found another one, attached below. The free_bootmem() in arch/powerpc/platforms/82xx/pq2ads-pci-pic.c looks also fishy, since it's applied to memory from kzalloc(). Ben? Signed-off-by: Johannes Weiner <[email protected]> --- diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c index 7d5a6b4..1963680 100644 --- a/drivers/macintosh/smu.c +++ b/drivers/macintosh/smu.c @@ -565,7 +565,7 @@ int __init smu_init (void) fail_db_node: of_node_put(smu->db_node); fail_bootmem: - free_bootmem((unsigned long)smu, sizeof(struct smu_device)); + free_bootmem(__pa(smu), sizeof(struct smu_device)); smu = NULL; fail_np: of_node_put(np); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
