On Tue, Sep 25, 2012 at 12:20 AM, Murali Karicheri <[email protected]> wrote:
> +struct clk_davinci_pll_data {
> + /* physical addresses set by platform code */
> + u32 phy_pllm;
> + /* if PLL has a prediv register this should be non zero */
> + u32 phy_prediv;
> + /* if PLL has a postdiv register this should be non zero */
> + u32 phy_postdiv;
> + /* mapped addresses. should be initialized by */
> + void __iomem *pllm;
> + void __iomem *prediv;
> + void __iomem *postdiv;
> + u32 pllm_mask;
> + u32 prediv_mask;
> + u32 postdiv_mask;
> + u32 num;
> + /* framework flags */
> + u32 flags;
> + /* pll flags */
> + u32 pll_flags;
> + u32 fixed_prediv; /* use this value for prediv */
> + u32 pllm_multiplier; /* multiply PLLM by this factor. By default
> + * most SOC set this to zero that translates
> + * to a multiplier of 1 and incrementer of 1.
> + * To override default, set this factor */
> +};
OMG this commenting style hurt my eyes ;-)
Please use good old kerneldoc above the struct instead.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
