> The Sensortek STK36C61 is a 3-in-1 ambient light / proximity / RGB > colour sensor. Its register interface is compatible with the feature > set this driver uses. Add its chip ID to the known-ID list and the > device table entries. > > Whenever the ALS engine runs, the chip also measures four colour > channels: red, green, blue and clear, laid out directly after the > ALS data as 16-bit big-endian values. > > R, G and B are gained by the same ALSCTRL gain field the illuminance > channel uses, clear by its own gain field in the GAINCTRL register, > and the whole colour block integrates over the ALS integration time. > Expose the channels with per-channel scale and a shared integration > time, as suggested by Jonathan Cameron for the green channel. > > The scales reuse the driver's existing gain-only table: green equals > the ALS data, so its scale must read identically to the pre-existing > in_illuminance_scale. > > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Jorijn van der Graaf <[email protected]>
So there is a Sashiko comment on this one. It's an exisiting issue in the tear down path so out of scope for this series. In general we probably need to look at the various things that might get called on late running or spurious interrupts to be sure they are safely dropped. Anyhow, yet another thing for the todo list. > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio > b/Documentation/ABI/testing/sysfs-bus-iio > index a4f5595722ad..08a8de215814 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio We'd normally do a core ABI docs update in a separate patch, but it is such a small one I'm not going to ask you to respin for that! > @@ -507,6 +507,7 @@ What: > /sys/bus/iio/devices/iio:deviceX/in_intensity_z_scale > What: /sys/bus/iio/devices/iio:deviceX/in_intensity_red_scale > What: > /sys/bus/iio/devices/iio:deviceX/in_intensity_green_scale > What: /sys/bus/iio/devices/iio:deviceX/in_intensity_blue_scale > +What: > /sys/bus/iio/devices/iio:deviceX/in_intensity_clear_scale > What: > /sys/bus/iio/devices/iio:deviceX/in_concentration_co2_scale > What: /sys/bus/iio/devices/iio:deviceX/in_volumeflow_scale > What: /sys/bus/iio/devices/iio:deviceX/in_volumeflowY_scale Thanks Jonathan -- Jonathan Cameron <[email protected]>
