On Tue, Aug 04, 2026 at 06:54:24PM +0200, Markus Elfring wrote: > How good does a proposed snet_free_irqs(snet) call fit to previous > devm_request_irq() calls? > > I suggest to avoid duplicate exception handling code for affected cases.
The IRQs are requested and freed while the PCI device remains bound, for example when DRIVER_OK is set and later reset. So the driver cannot rely only on devres cleanup at device detach time; it already pairs devm_request_irq() with devm_free_irq() in snet_free_irqs() for reset and for the snet_write_conf() failure path. That said, I agree that the error path can be made more precise. I will send a v2 that keeps the config IRQ request failure as a direct return, and only calls snet_free_irqs() after at least one IRQ was successfully requested. I will also add the Fixes/Cc stable tags. Thanks, Xiong
