On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote: > On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote: > > From: Hongfu Li <[email protected]> > > > > mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice. > > The second run repeats all assertions with no benefit. Drop the > > duplicate call. > > > > Signed-off-by: Hongfu Li <[email protected]> > > :)) > > LGTM so > > Reviewed-by: Lorenzo Stoakes (ARM) <[email protected]>
Sorry Pedro mentioned off-list that you need to update the number of tests specified, e.g.: - ksft_set_plan(88); + ksft_set_plan(87); In main(). Update that and send a respin and you can attach my tag to it. > > > --- > > tools/testing/selftests/mm/mseal_test.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tools/testing/selftests/mm/mseal_test.c > > b/tools/testing/selftests/mm/mseal_test.c > > index 93c2e13094d4..babc217d9dc9 100644 > > --- a/tools/testing/selftests/mm/mseal_test.c > > +++ b/tools/testing/selftests/mm/mseal_test.c > > @@ -1913,7 +1913,6 @@ int main(void) > > test_seal_mprotect_partial_mprotect(false); > > test_seal_mprotect_partial_mprotect(true); > > > > - test_seal_mprotect_two_vma_with_gap(); > > test_seal_mprotect_two_vma_with_gap(); > > > > test_seal_mprotect_merge(false); > > -- > > 2.54.0 > > > > -- > Cheers, Lorenzo -- Cheers, Lorenzo
