On 7/3/26 22:38, Mukesh Ojha wrote: > Replace the hand-rolled devm_hdmirx_of_reserved_mem_device_release() > devres action with devm_of_reserved_mem_device_init(), which handles the > cleanup automatically. This removes both the wrapper function and the > devm_add_action_or_reset() call. > > Signed-off-by: Mukesh Ojha <[email protected]> > --- > .../media/platform/synopsys/hdmirx/snps_hdmirx.c | 16 ++-------------- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c > b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c > index 25f8ca0d6d94..7c6acc6d7e88 100644 > --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c > +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c > @@ -2265,11 +2265,6 @@ static const struct hdmirx_cec_ops hdmirx_cec_ops = { > .read = hdmirx_readl, > }; > > -static void devm_hdmirx_of_reserved_mem_device_release(void *dev) > -{ > - of_reserved_mem_device_release(dev); > -} > - > static int hdmirx_parse_dt(struct snps_hdmirx_dev *hdmirx_dev) > { > struct device *dev = hdmirx_dev->dev; > @@ -2316,16 +2311,9 @@ static int hdmirx_parse_dt(struct snps_hdmirx_dev > *hdmirx_dev) > if (!device_property_read_bool(dev, "hpd-is-active-low")) > hdmirx_dev->hpd_trigger_level_high = true; > > - ret = of_reserved_mem_device_init(dev); > - if (ret) { > + ret = devm_of_reserved_mem_device_init(dev); > + if (ret) > dev_warn(dev, "no reserved memory for HDMIRX, use default > CMA\n"); > - } else { > - ret = devm_add_action_or_reset(dev, > - > devm_hdmirx_of_reserved_mem_device_release, > - dev); > - if (ret) > - return ret; > - } > > return 0; > }
Reviewed-by: Dmitry Osipenko <[email protected]> -- Best regards, Dmitry
