On Thu, Feb 26, 2026 at 11:17:49AM -0800, Eric Biggers wrote: > The convention for KUnit tests is to have the test kconfig options > visible only when the code they depend on is already enabled. This way > only the tests that are relevant to the particular kernel build can be > enabled, either manually or via KUNIT_ALL_TESTS. > > Update lib/crypto/tests/Kconfig to follow that convention, i.e. depend > on the corresponding library options rather than selecting them. This > fixes an issue where enabling KUNIT_ALL_TESTS enabled non-test code. > > This does mean that it becomes more difficult to enable *all* the crypto > library tests (which is what I do as a maintainer of the code), since > doing so will now require enabling other options that select the > libraries. Regardless, we should follow the standard KUnit convention. > > Note: currently most of the crypto library options are selected by > visible options in crypto/Kconfig, which can be used to enable them > without too much trouble. If in the future we end up with more cases > like CRYPTO_LIB_CURVE25519 which is selected only by WIREGUARD (thus > making CRYPTO_LIB_CURVE25519_KUNIT_TEST effectively depend on WIREGUARD > after this commit), we could consider adding a new kconfig option that > enables all the library code specifically for testing. > > Reported-by: Geert Uytterhoeven <[email protected]> > Closes: > https://lore.kernel.org/r/camuhmdvfrqzxckjbobdjtpenvpvo39axgmufwvqdm6xktpn...@mail.gmail.com > Fixes: 4dcf6caddaa0 ("lib/crypto: tests: Add KUnit tests for SHA-224 and > SHA-256") > Fixes: 571eaeddb67d ("lib/crypto: tests: Add KUnit tests for SHA-384 and > SHA-512") > Fixes: 6dd4d9f7919e ("lib/crypto: tests: Add KUnit tests for Poly1305") > Fixes: 66b130607908 ("lib/crypto: tests: Add KUnit tests for SHA-1 and > HMAC-SHA1") > Fixes: d6b6aac0cdb4 ("lib/crypto: tests: Add KUnit tests for MD5 and > HMAC-MD5") > Fixes: afc4e4a5f122 ("lib/crypto: tests: Migrate Curve25519 self-test to > KUnit") > Fixes: 6401fd334ddf ("lib/crypto: tests: Add KUnit tests for BLAKE2b") > Fixes: 15c64c47e484 ("lib/crypto: tests: Add SHA3 kunit tests") > Fixes: b3aed551b3fc ("lib/crypto: tests: Add KUnit tests for POLYVAL") > Fixes: ed894faccb8d ("lib/crypto: tests: Add KUnit tests for ML-DSA > verification") > Fixes: 7246fe6cd644 ("lib/crypto: tests: Add KUnit tests for NH") > Cc: [email protected] > Signed-off-by: Eric Biggers <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-fixes - Eric
