Re: [PATCH v2 18/18] vfio: selftests: Add vfio_pci_device_init_perf_test

[David Matlack]

On Wed, Nov 12, 2025 at 2:54 PM Alex Mastro <amas...@fb.com> wrote:
>
> On Wed, Nov 12, 2025 at 07:22:32PM +0000, David Matlack wrote:
> > +static s64 to_ns(struct timespec ts)
> > +{
> > +     return (s64)ts.tv_nsec + 1000000000LL * (s64)ts.tv_sec;
> > +}
> > +
> > +static struct timespec to_timespec(s64 ns)
> > +{
> > +     struct timespec ts = {
> > +             .tv_nsec = ns % 1000000000LL,
> > +             .tv_sec = ns / 1000000000LL,
>
> nit - I think you can get NSEC_PER_SEC from #include <linux/time64.h>

Thanks for the tip. I'll include that in v3.

>
> Otherwise LGTM
>
> Reviewed-by: Alex Mastro <amas...@fb.com>