Re: [PATCH RFC 6/8] media: qcom: camss: csiphy-3ph: Use sdm845 C-PHY configuration sequence

[Luca Weiss]

On Sun Nov 9, 2025 at 10:39 AM CET, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <da...@ixit.cz>
>
> Enable the 3-phase (3PH) lane configuration introduced earlier when
> C-PHY mode is requested on the SDM845 platform. This ensures the proper
> initialization sequence is used for C-PHY operation.
>
> Signed-off-by: David Heidelberg <da...@ixit.cz>
> ---
>  drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c 
> b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> index c2adbde6b4e0d..03f5c4676e89a 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> @@ -1103,8 +1103,14 @@ static void csiphy_lanes_enable(struct csiphy_device 
> *csiphy,
>  
>       switch (csiphy->camss->res->version) {
>       case CAMSS_845:
> -             regs->lane_regs = &lane_regs_sdm845[0];
> -             regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845);
> +             if (c->cphy) {
> +                     regs->lane_regs = &lane_regs_sdm845_3ph[0];
> +                     regs->lane_array_size = 
> ARRAY_SIZE(lane_regs_sdm845_3ph);
> +
> +             } else {
> +                     regs->lane_regs = &lane_regs_sdm845[0];
> +                     regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845);
> +             }

Why not add this directly in the commit adding the sequence? Otherwise
the other commit adding lane_regs_sdm845_3ph will just have an unused
variable warning until this patch.

I think it's one logical change.

Regards
Luca

>               break;
>       case CAMSS_2290:
>               regs->lane_regs = &lane_regs_qcm2290[0];