Pointer arthemitic with 'void * addr' and 'unsigned long long dest_alignment'
triggers following warning:
mremap_test.c:1035:31: warning: pointer comparison always evaluates to
false [-Wtautological-compare]
1035 | if (addr + c.dest_alignment < addr) {
| ^
typecasting 'addr' to 'unsigned long long' to fix pointer comparison.
Signed-off-by: Ankit Khushwaha <[email protected]>
---
tools/testing/selftests/mm/mremap_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/mremap_test.c
b/tools/testing/selftests/mm/mremap_test.c
index a95c0663a011..5ae0400176af 100644
--- a/tools/testing/selftests/mm/mremap_test.c
+++ b/tools/testing/selftests/mm/mremap_test.c
@@ -1032,7 +1032,7 @@ static long long remap_region(struct config c, unsigned
int threshold_mb,
/* Don't destroy existing mappings unless expected to overlap */
while (!is_remap_region_valid(addr, c.region_size) && !c.overlapping) {
/* Check for unsigned overflow */
- if (addr + c.dest_alignment < addr) {
+ if ((unsigned long long) addr + c.dest_alignment < (unsigned
long long) addr) {
ksft_print_msg("Couldn't find a valid region to remap
to\n");
ret = -1;
goto clean_up_src;
--
2.51.0
