On Fri, Oct 31, 2025 at 8:50 PM Frank Li <[email protected]> wrote: > > On Fri, Oct 31, 2025 at 05:08:32PM +0800, Peng Fan wrote: > > Replace manual pm_runtime_enable() with devm_pm_runtime_enable() to > > leverage device-managed cleanup and simplify resource handling. > > > > pm_runtime_disable_action() not only calls pm_runtime_disable(), but > > also calls pm_runtime_dont_use_autosuspend(). The current driver > > only calls pm_runtime_disable(). But this should be fine here to use > > devm_pm_runtime_enable(). > > looks like this paragaph is reduntant.
This is not redundant! But it can be phrased better. ``` Current code on the cleanup path just disables runtime PM for a device. Using resource managed version devm_pm_runtime_enable registers a cleanup callback that sets autosuspend to false and then disables runtime PM for a device. So, basically the same functionality as we don't use autosuspend anyway. ``` thanks, Daniel.
