On Tue, Nov 04, 2025 at 04:58:58PM +0000, Bryan O'Donoghue wrote: > On 04/11/2025 07:35, Mukesh Ojha wrote: > > Remove some redundant piece of code to save some machine cycle. > > > > Signed-off-by: Mukesh Ojha <[email protected]> > > --- > > drivers/firmware/qcom/qcom_scm.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/firmware/qcom/qcom_scm.c > > b/drivers/firmware/qcom/qcom_scm.c > > index e777b7cb9b12..26969bcd763c 100644 > > --- a/drivers/firmware/qcom/qcom_scm.c > > +++ b/drivers/firmware/qcom/qcom_scm.c > > @@ -650,8 +650,6 @@ void qcom_scm_pas_metadata_release(struct > > qcom_scm_pas_metadata *ctx) > > dma_free_coherent(__scm->dev, ctx->size, ctx->ptr, ctx->phys); > > > > ctx->ptr = NULL; > > - ctx->phys = 0; > > - ctx->size = 0; > > } > > EXPORT_SYMBOL_GPL(qcom_scm_pas_metadata_release); > > > > > > -- > > 2.50.1 > > > > > > Please fix the commit log.
how about this ? "" The qcom_scm_pas_metadata_release() function already frees the allocated memory and sets ctx->ptr to NULL. Resetting ctx->phys and ctx->size to zero is unnecessary because the context is expected to be discarded after release. Lets removes redundant assignments. "" > > --- > bod -- -Mukesh Ojha
