damon_test_ops_registration() is assuming all dynamic memory allocation
in it will succeed.  Those are indeed likely in the real use cases since
those allocations are too small to fail, but theoretically those could
fail.  In the case, inappropriate memory access can happen.  Fix it by
appropriately cleanup pre-allocated memory and skip the execution of the
remaining tests in the failure cases.

Fixes: 4f540f5ab4f2 ("mm/damon/core-test: add a kunit test case for ops 
registration")
Cc: <[email protected]> # 5.19.x
Signed-off-by: SeongJae Park <[email protected]>
---
 mm/damon/tests/core-kunit.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 10618cdd188e..96c8f1269f44 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -320,6 +320,9 @@ static void damon_test_ops_registration(struct kunit *test)
        struct damon_operations ops = {.id = DAMON_OPS_VADDR}, bak;
        bool need_cleanup = false;
 
+       if (!c)
+               kunit_skip(test, "ctx alloc fail");
+
        /* DAMON_OPS_VADDR is registered only if CONFIG_DAMON_VADDR is set */
        if (!damon_is_registered_ops(DAMON_OPS_VADDR)) {
                bak.id = DAMON_OPS_VADDR;
-- 
2.47.3

Reply via email to