On Thu, Oct 9, 2025 at 3:15 PM Maxime Coquelin <[email protected]> wrote: > > > > On 10/7/25 3:06 PM, Eugenio Pérez wrote: > > Now that the virtio_net driver is able to recover from a stall > > virtqueue, let's lift the restriction. > > > > Signed-off-by: Eugenio Pérez <[email protected]> > > --- > > drivers/vdpa/vdpa_user/vduse_dev.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c > > b/drivers/vdpa/vdpa_user/vduse_dev.c > > index e7bced0b5542..95d2b898171d 100644 > > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > > @@ -1726,9 +1726,6 @@ static bool features_is_valid(struct vduse_dev_config > > *config) > > if ((config->device_id == VIRTIO_ID_BLOCK) && > > (config->features & BIT_ULL(VIRTIO_BLK_F_CONFIG_WCE))) > > return false; > > - else if ((config->device_id == VIRTIO_ID_NET) && > > - (config->features & BIT_ULL(VIRTIO_NET_F_CTRL_VQ))) > > - return false; > > > > if ((config->device_id == VIRTIO_ID_NET) && > > !(config->features & BIT_ULL(VIRTIO_F_VERSION_1))) > > I wonder whether the API version should be increased, otherwise I don't > see how the app creating the VDUSE device knows whether it can safely > advertises the CVQ support (except without doing trial and error). >
Ok good point! I'll do it in the next version.
