On Tue, Sep 30, 2025 at 10:02:03AM +0100, Simon Horman wrote:
> On Tue, Sep 30, 2025 at 09:59:44AM +0100, Simon Horman wrote:
> > On Mon, Sep 29, 2025 at 10:01:38PM +0530, Gopi Krishna Menon wrote:
> > > Add the tcp_port_share test binary to .gitignore to avoid
> > > accidentally staging the build artifact.
> > >
> > > Fixes: 8a8241cdaa34 ("selftests/net: Test tcp port reuse after unbinding
> > > a socket")
> >
> > I'm not entirely sure this qualifies for a fixes tag.
> > It is user-visible. It's probably annoying.
> > But I'm not sure it's a bug.
Hi Simon, thanks for the review. I also feel that Fixes tag is not
required for this change. I added it based on this earlier
commit(7ae495a537d1):
https://lore.kernel.org/all/[email protected]
but other commits similar in nature dont have the fixes tag, therefore I
will remove it in v2.
>
> Also, FTR, fixes tag's shouldn't be line wrapped.
>
> > > Signed-off-by: Gopi Krishna Menon <[email protected]>
> > > ---
> > > tools/testing/selftests/net/.gitignore | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > Reviewed-by: Simon Horman <[email protected]>
> >
> > I notice that tools/testing/selftests/kexec/test_kexec_jump
> > is in a similar state. Do you plan to send a patch to address
> > that too?
> >
> > ..
This has been already addressed and will be in 6.18-rc1 I believe:
https://lore.kernel.org/all/[email protected]/
>
> Please note that net-next is now closed.
>
> So if you do respin, please wait for it to re-open once v6.18-rc1 has been
> released. About two weeks from now.
Noted, I will send a v2 for this patch when net-next will be reopened.
