On Thu, Sep 18, 2025 at 07:51:18PM +0800, Peng Fan wrote:
> PM runtime support is safe and applicable across all i.MX platforms, not
> just those using the SCU API. Remove the conditional check and enable PM
> runtime unconditionally to simplify the code and ensure consistent power
> management behavior.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
Reviewed-by: Frank Li <[email protected]>
> drivers/remoteproc/imx_rproc.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index
> 74c958d44611b66e024180d69d71daac5a2f9e76..69b57cb4b251d9fb65a23e139a1960bf29c175ed
> 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -1123,19 +1123,17 @@ static int imx_rproc_probe(struct platform_device
> *pdev)
> return dev_err_probe(dev, ret, "register restart
> handler failure\n");
> }
>
> - if (dcfg->method == IMX_RPROC_SCU_API) {
> - ret = devm_pm_runtime_enable(dev);
> - if (ret)
> - return dev_err_probe(dev, ret, "Failed to enable
> runtime PM\n");
> + ret = devm_pm_runtime_enable(dev);
> + if (ret)
> + return dev_err_probe(dev, ret, "Failed to enable runtime PM\n");
>
> - ret = pm_runtime_resume_and_get(dev);
> - if (ret)
> - return dev_err_probe(dev, ret, "pm_runtime get
> failed\n");
> + ret = pm_runtime_resume_and_get(dev);
> + if (ret)
> + return dev_err_probe(dev, ret, "pm_runtime get failed\n");
>
> - ret = devm_add_action_or_reset(dev, imx_rproc_pm_runtime_put,
> dev);
> - if (ret)
> - return dev_err_probe(dev, ret, "Failed to add devm
> disable pm action\n");
> - }
> + ret = devm_add_action_or_reset(dev, imx_rproc_pm_runtime_put, dev);
> + if (ret)
> + return dev_err_probe(dev, ret, "Failed to add devm disable pm
> action\n");
>
> ret = devm_rproc_add(dev, rproc);
> if (ret)
>
> --
> 2.37.1
>
