On Fri, 5 Sep 2025 16:39:05 +0300 Andy Shevchenko <[email protected]> wrote:
> On Fri, Sep 5, 2025 at 2:01 PM Duje Mihanović <[email protected]> wrote: > > > > Marvell's 88PM886 PMIC has a so-called General Purpose ADC used for > > monitoring various system voltages and temperatures. Add the relevant > > register definitions to the MFD header and a driver for the ADC. > > Jonathan et al. The Q here is do we want to somehow make values > spelling (in the comments and documentation) be unified with the > Scientific Style [1]? Personally I find the article very useful and > one style for the whole subsystem would be good to enforce (in my > humble opinion). Thoughts? > > [1]: https://poynton.ca/notes/units/ I should have included in previous reply that I would not want this driver stalled on that discussion, so let us guess the outcome and go with the unit formatting suggestions Andy makes in this review. The question of standardising on this aspect and documenting it can be resolved in parallel. Jonathan
