On Thu, 3 Oct 2024 at 04:39, Shuah Khan <[email protected]> wrote: > > On 9/30/24 17:18, Jacob Keller wrote: > > > > > > On 9/22/2024 8:05 AM, Guenter Roeck wrote: > >> This reverts commit e620799c414a035dea1208bcb51c869744931dbb. > >> > >> The commit introduces unit test failures. > >> > >> Expected cur == &entries[i], but > >> cur == 0000037fffadfd80 > >> &entries[i] == 0000037fffadfd60 > >> # list_test_list_cut_position: pass:0 fail:1 skip:0 total:1 > >> not ok 21 list_test_list_cut_position > >> # list_test_list_cut_before: EXPECTATION FAILED at > >> lib/list-test.c:444 > >> Expected cur == &entries[i], but > >> cur == 0000037fffa9fd70 > >> &entries[i] == 0000037fffa9fd60 > >> # list_test_list_cut_before: EXPECTATION FAILED at > >> lib/list-test.c:444 > >> Expected cur == &entries[i], but > >> cur == 0000037fffa9fd80 > >> &entries[i] == 0000037fffa9fd70 > >> > >> Revert it. > >> > >> Fixes: e620799c414a ("list: test: fix tests for list_cut_position()") > >> Cc: I Hsin Cheng <[email protected]> > >> Cc: David Gow <[email protected]> > >> Cc: Andrew Morton <[email protected]> > >> Signed-off-by: Guenter Roeck <[email protected]> > >> --- > > > > I ran into this as well. > > > > Reviewed-by: Jacob Keller <[email protected]> > > > > Please take a look and let me know if you are okay with this patch.
This (and the original patch which was reverted) were both picked up via another tree and have already been applied to torvalds/master. A re-work of the original patch is in https://lore.kernel.org/linux-kselftest/[email protected]/ -- it looks fine to me (modulo the description being a bit confusing) and should be applied as a new patch, ignoring this and the previous version. -- David
smime.p7s
Description: S/MIME Cryptographic Signature
