Re: [PATCH] Revert "list: test: fix tests for list_cut_position()"

[Shuah Khan]

On 9/30/24 17:18, Jacob Keller wrote:

On 9/22/2024 8:05 AM, Guenter Roeck wrote:

This reverts commit e620799c414a035dea1208bcb51c869744931dbb.

The commit introduces unit test failures.

      Expected cur == &entries[i], but
          cur == 0000037fffadfd80
          &entries[i] == 0000037fffadfd60
      # list_test_list_cut_position: pass:0 fail:1 skip:0 total:1
      not ok 21 list_test_list_cut_position
      # list_test_list_cut_before: EXPECTATION FAILED at lib/list-test.c:444
      Expected cur == &entries[i], but
          cur == 0000037fffa9fd70
          &entries[i] == 0000037fffa9fd60
      # list_test_list_cut_before: EXPECTATION FAILED at lib/list-test.c:444
      Expected cur == &entries[i], but
          cur == 0000037fffa9fd80
          &entries[i] == 0000037fffa9fd70

Revert it.

Fixes: e620799c414a ("list: test: fix tests for list_cut_position()")
Cc: I Hsin Cheng <richard120...@gmail.com>
Cc: David Gow <david...@google.com>
Cc: Andrew Morton <a...@linux-foundation.org>
Signed-off-by: Guenter Roeck <li...@roeck-us.net>
---

I ran into this as well.

Reviewed-by: Jacob Keller <jacob.e.kel...@intel.com>

Please take a look and let me know if you are okay with this patch.

thanks,
-- Shuah