On 6/17/24 20:38, Daniel Wagner wrote: > Use libtracefs as package name to lookup the CFLAGS for libtracefs. This > makes it possible to use the distro specific path as include path for > the header file.
So, I added it to my review branch and tested it. It is fine! But, as the most important user of this build system is perf, I think it is safer to ask them to review, test, and integrate it. I Cc'ing some perf people here, but it might be worth sending a v2 with all perf crew in Cc. It is also worth checking which Fixes to use between: b758a61b391f perf tools: Enable libtracefs dynamic linking a87834d19aa2 perf build: Fix broken feature check for libtracefs due to external lib changes To avoid breaking older perf versions. For rtla, Tested-by: Daniel Bristot de Oliveira <[email protected]> -- Daniel > Signed-off-by: Daniel Wagner <[email protected]> > --- > Our downstream packaging stop working. After a bit of didding I found out that > the libtracefs feature detection is not completely right. > > https://build.opensuse.org/build/benchmark/SLE_15_SP5/x86_64/rtla/_log > --- > tools/build/feature/Makefile | 2 +- > tools/build/feature/test-libtracefs.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile > index ed54cef450f5..489cbed7e82a 100644 > --- a/tools/build/feature/Makefile > +++ b/tools/build/feature/Makefile > @@ -213,7 +213,7 @@ endif > $(BUILD) -ltraceevent > > $(OUTPUT)test-libtracefs.bin: > - $(BUILD) $(shell $(PKG_CONFIG) --cflags libtraceevent 2>/dev/null) > -ltracefs > + $(BUILD) $(shell $(PKG_CONFIG) --cflags libtracefs 2>/dev/null) > -ltracefs > > $(OUTPUT)test-libcrypto.bin: > $(BUILD) -lcrypto > diff --git a/tools/build/feature/test-libtracefs.c > b/tools/build/feature/test-libtracefs.c > index 8eff16c0c10b..29a757a7d848 100644 > --- a/tools/build/feature/test-libtracefs.c > +++ b/tools/build/feature/test-libtracefs.c > @@ -1,5 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > -#include <tracefs/tracefs.h> > +#include <tracefs.h> > > int main(void) > { > > --- > base-commit: 0bbac3facb5d6cc0171c45c9873a2dc96bea9680 > change-id: 20240617-rtla-build-83020baf9277 > > Best regards,
