On Wed, May 15, 2024 at 11:05 PM Michael S. Tsirkin <[email protected]> wrote: > > There are two issues around seqpacket_allow: > 1. seqpacket_allow is not initialized when socket is > created. Thus if features are never set, it will be > read uninitialized. > 2. if VIRTIO_VSOCK_F_SEQPACKET is set and then cleared, > then seqpacket_allow will not be cleared appropriately > (existing apps I know about don't usually do this but > it's legal and there's no way to be sure no one relies > on this). > > To fix: > - initialize seqpacket_allow after allocation > - set it unconditionally in set_features > > Reported-by: [email protected] > Reported-by: Jeongjun Park <[email protected]> > Fixes: ced7b713711f ("vhost/vsock: support SEQPACKET for transport"). > Cc: Arseny Krasnov <[email protected]> > Cc: David S. Miller <[email protected]> > Cc: Stefan Hajnoczi <[email protected]> > Signed-off-by: Michael S. Tsirkin <[email protected]> > Acked-by: Arseniy Krasnov <[email protected]> > Tested-by: Arseniy Krasnov <[email protected]> >
Acked-by: Jason Wang <[email protected]> Thanks
