Looks good to me. Reviewed-by: Karan Tilak Kumar <[email protected]>
Regards, Karan -----Original Message----- From: Zhang Changzhong <[email protected]> Sent: Thursday, December 3, 2020 11:48 PM To: Satish Kharat (satishkh) <[email protected]>; Sesidhar Baddela (sebaddel) <[email protected]>; Karan Tilak Kumar (kartilak) <[email protected]>; James E.J. Bottomley <[email protected]>; Martin K. Petersen <[email protected]>; James Bottomley <[email protected]>; Mike Christie <[email protected]>; Joe Eykholt <[email protected]>; Abhijeet Joglekar <[email protected]> Cc: [email protected]; [email protected] Subject: [PATCH] scsi: fnic: fix error return code in fnic_probe() Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 5df6d737dd4b ("[SCSI] fnic: Add new Cisco PCI-Express FCoE HBA") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Zhang Changzhong <[email protected]> --- drivers/scsi/fnic/fnic_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c index 5f8a7ef..4f7befb 100644 --- a/drivers/scsi/fnic/fnic_main.c +++ b/drivers/scsi/fnic/fnic_main.c @@ -740,6 +740,7 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) for (i = 0; i < FNIC_IO_LOCKS; i++) spin_lock_init(&fnic->io_req_lock[i]); + err = -ENOMEM; fnic->io_req_pool = mempool_create_slab_pool(2, fnic_io_req_cache); if (!fnic->io_req_pool) goto err_out_free_resources; -- 2.9.5
