From: Era Mayflower <[email protected]>
Date: Thu, 10 Sep 2020 09:56:09 +0000
> - pn_len = secy->xpn ? MACSEC_XPN_PN_LEN : MACSEC_DEFAULT_PN_LEN;
> - if (nla_len(tb_sa[MACSEC_SA_ATTR_PN]) != pn_len) {
> - pr_notice("macsec: nl: upd_rxsa: bad pn length: %d !=
> %d\n",
> - nla_len(tb_sa[MACSEC_SA_ATTR_PN]), pn_len);
> + pr_notice("macsec: nl: upd_rxsa: pn length on non-xpn
> links must be %d\n",
> + MACSEC_DEFAULT_PN_LEN);
> + rtnl_unlock();
> + return -EINVAL;
> +
> + default:
> + pr_notice("macsec: nl: upd_rxsa: pn length must be %d
> or %d\n",
> + MACSEC_DEFAULT_PN_LEN, MACSEC_XPN_PN_LEN);
> rtnl_unlock();
Please do not spam the kernel log like this. Instead, report this
info via netlink extended ACKs.
Thank you.
