On Fri, 26 Jun 2020, Arnd Bergmann wrote: > On Fri, Jun 26, 2020 at 3:05 PM Lee Jones <[email protected]> wrote: > > > > Hasn't been checked since its conception 2 years ago. > > > > Squashes W=1 warning: > > > > drivers/misc/mic/vop/vop_main.c: In function ‘_vop_scan_devices’: > > drivers/misc/mic/vop/vop_main.c:617:6: warning: variable ‘ret’ set but not > > used [-Wunused-but-set-variable] > > 617 | int ret; > > | ^~~ > > > > Cc: Sudeep Dutt <[email protected]> > > Cc: Ashutosh Dixit <[email protected]> > > Cc: Christian Borntraeger <[email protected]> > > Signed-off-by: Lee Jones <[email protected]> > > This is a correct change, but I'd take it one step further and make the > _vop_remove_device() function return 'void' if you don't mind > respinning the patch. > > Either way > > Acked-by: Arnd Bergmann <[email protected]>
Thanks. Do you mind if I handle your request as a subsequent patch? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
