Re: [PATCH 6/6] arm64: dts: qcom: add sm8250 hdk dts

[Jonathan Marek]

On 5/28/20 11:03 PM, Bjorn Andersson wrote:

On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote:

Add initial HDK865 dts, based on sm8250-mtp, with a few changes.
Notably, regulator configs are changed a bit.

Signed-off-by: Jonathan Marek <jonat...@marek.ca>
---
  arch/arm64/boot/dts/qcom/Makefile       |   1 +
  arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 ++++++++++++++++++++++++
  2 files changed, 455 insertions(+)
  create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile 
b/arch/arm64/boot/dts/qcom/Makefile
index e5dbd8b63951..4649e8bc5034 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -24,6 +24,7 @@ dtb-$(CONFIG_ARCH_QCOM)       += sdm845-mtp.dtb
  dtb-$(CONFIG_ARCH_QCOM)       += sdm850-lenovo-yoga-c630.dtb
  dtb-$(CONFIG_ARCH_QCOM)       += sm8150-hdk.dtb
  dtb-$(CONFIG_ARCH_QCOM)       += sm8150-mtp.dtb
+dtb-$(CONFIG_ARCH_QCOM)        += sm8250-hdk.dtb
  dtb-$(CONFIG_ARCH_QCOM)       += sm8250-mtp.dtb
  dtb-$(CONFIG_ARCH_QCOM)       += qcs404-evb-1000.dtb
  dtb-$(CONFIG_ARCH_QCOM)       += qcs404-evb-4000.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8250-hdk.dts 
b/arch/arm64/boot/dts/qcom/sm8250-hdk.dts
new file mode 100644
index 000000000000..d35014bf4f81
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8250-hdk.dts
@@ -0,0 +1,454 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2020, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include <dt-bindings/gpio/gpio.h>
+#include "sm8250.dtsi"
+#include "pm8150.dtsi"
+#include "pm8150b.dtsi"
+#include "pm8150l.dtsi"
+
+/ {
+       model = "Qualcomm Technologies, Inc. SM8250 HDK";
+       compatible = "qcom,sm8250-hdk";

        compatible = "qcom,sm8250-hdk", "qcom,sm8250";

Apart from that this looks good!

Made this change for both HDK dts, but FYI the mtp dts do not have this.

Thanks,
Bjorn